fix: correctly restore type-only import/export names #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
approved these changes
Feb 26, 2025
|
I’ve got to say, it’s been really tough for me trying to figure out how to implement this feature 🥲🥲 Hope to hear your feedback ❤️ |
Swatinem
approved these changes
Feb 28, 2025
|
To be quite honest, I haven’t really been maintaining this project for years, so I’m not that familiar with the code anymore myself to be of much help here. But I do trust the testsuite quite a bit, and the results look good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #311
This is a rework of PR: #333 🫡
AssignmentExpressionto record the type-only hints (Instead of renaming import/export variables previously, since it's unstable and has some minor flaws.)ExportFixerintoTypeOnlyFixersince it's now part ofTypeOnlyFixer's responsibilities